Refactor startupgenome_get.php to consume Startup Genome API using CURL.#29
Open
nickgs wants to merge 1 commit intoabenzer:masterfrom
Open
Refactor startupgenome_get.php to consume Startup Genome API using CURL.#29nickgs wants to merge 1 commit intoabenzer:masterfrom
nickgs wants to merge 1 commit intoabenzer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Issue #23, it looks like the HTTP class that is being used in this file was not persisting the AUTH_CODE header. I've refactored the file to use CURL and it seems to be working well.
Not sure if this is something we want to include in the project being that I have removed alot of the error checking that was in place BUT it does work.
Figured I would post the pull request just to see if there was any interest.
Thanks.